Most days the best thing to scrap is whatever happens to be available in the largest quantity. Varies month by month...
But I always like copper and brass. Currently I have a lot with aluminum, so because of volume it's my best item, this month anyway!